Date range listing unexpected behaviour when using EU date format

Support
1

This is a continuation of two previous posts - one here and another here.

Since then I have had time to test this thoroughly on clean installs of 1.7.48 with no plugins, quark theme and any edits made in the terminal (nano). It has been tested on several servers (incl. MacOS and debian) and PHP versions 8.3 and 8.4 with consistent results.

Note this only happens when using EU date formats (DD-MM-YYYY) in the page listing date range and frontmatter.

I have made it easy to reproduce by providing files to drop into a clean install - in both EU and US formats so you can compare.

There is a template file with a collection listing and a dat range listing - test.html.twig:

{% extends 'partials/base.html.twig' %}

{% block content %}

    {{ page.content|raw }}    

    <h1>Grav version 1.7.48</h1>
    
    <h2>Collection listing</h2>
    <ul>
    {% for p in page.collection.order('date','desc') %}
		<li><a href="{{ p.permalink|e }}">{{ p.title|e }}</a> &mdash; {{ p.date|date|e }}</li>
	{% endfor %}
	</ul>
	
    <h2>Date range listing</h2>
    <ul>
    {% for p in page.collection.dateRange('01-01-2024', '31-12-2024').order('date','desc') %}
		<li><a href="{{ p.permalink|e }}">{{ p.title|e }}</a> &mdash; {{ p.date|date|e }}</li>
	{% endfor %}
	</ul>
    
{% endblock %}

and a 03.child-test folder where I define a test collection in test.md:

---
title: Child test
content:
  items: 
    '@self.children'
---

and three ‘child’ page folders (named child-one, child-two, child-three) each with a title and date field in frontmatter, e.g.:

---
title: Child one
date: 28-12-2024 14:18
---

Child one test page.

---

The remaining two child pages are in exactly the same format.

Steps to reproduce:

  • download Grav Core (I’m using 1.7.48)
  • download my test files
  • unzip both and open the Grav homepage in a browser
  • in my test files open the ‘EU-date-format’ folder and drop test.html.twig into /users/themes/quark/templates and the 03.child-test folder into /user/pages

With the files as they are (untouched) Child three is missing from the date range listing.

The date field of Child three reads date: 31-12-2024 13:53

With a text editor edit the date field of Child three to read date: 31-12-2024 and it appears in the date range listing!

Further observations re. Child three:

  • change the date to a day earlier - still with no time: date: 30-12-2024 - and it lists as expected
  • add a time date: 30-12-2024 14:43 and it still lists as expected
  • change the date to 31 December: date: 31-12-2024 14:43 and it disappears again from the date range listing.

This is not expected behaviour - but only occurs when using EU date formats DD-MM-YYYY.

My test folder contains duplicates of the above files but in US date format (in the folder US-date-format) so you can swap them to test. Using US date formats the pages list as they should.

I’d be grateful if you could test and confirm results.

2

@simfin,

TLDR:

  1. US and EU date formats show identical results
  2. Results for child-three are as expected/designed…

According the docs on dateRange:

The dateRange will filter out any pages that have a date outside (emphasis are mine) the provided dateRange

In code file /system/src/Grav/Common/Page/Collection.php lines 362-364 this is implemented as:

  • Note: $start and $end are the limits of dateRange and $date is page.date
    if ((!$start || $date >= $start) && (!$end || $date <= $end)) {
   $date_range[$path] = $slug;
}

Do the math:

  • Date 31-12-2024 equals 1735603200 equals December 31st at 12:00am
  • Date 31-12-2024 13:53 equals 1735653180 equals December 31st at 1:53pm
    • December 31st at 1:53pm is larger than December 31st at 12:00am hence it will be excluded from the range.

It seems the problem must be sought between the chair and the keyboard… :wink:

3

@ anon76427325

Thanks for explaining that - and for your patience. I had been assuming that the last date in a date range was included in the range.

So the way to write a full year date range listing would be to use the first day of the following year as the end date, e.g for 2024:

{% for p in page.collection.dateRange('01-01-2024', '01-01-2025') %}

That works as expected.